Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala-2-dependsOn-Scala-3 feature with Scala.js #5984

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Scala-2-dependsOn-Scala-3 feature with Scala.js #5984

merged 2 commits into from
Oct 18, 2020

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Oct 18, 2020

fix #5971

@xuwei-k xuwei-k requested a review from eed3si9n October 18, 2020 06:15
@xuwei-k xuwei-k mentioned this pull request Oct 18, 2020
Closed
eed3si9n
eed3si9n approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuwei-k!

@eed3si9n eed3si9n merged commit a9f62f8 into sbt:develop Oct 18, 2020
eed3si9n added a commit to sbt/sbt-projectmatrix that referenced this pull request Dec 2, 2020
@eed3si9n
Port fix for sandwich and Scala.JS
cb72b1e 
Ref sbt/sbt#5984
@xuwei-k xuwei-k mentioned this pull request Jan 23, 2021
Closed
@xuwei-k xuwei-k deleted the dotty-sandwich-scala-js branch January 23, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Scala-2-dependsOn-Scala-3 feature does not work for Scala.js projects
2 participants
@xuwei-k @eed3si9n