Implement Scala 2.13-3.0 sandwich #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like compiler bridge is being compiled twice? |
Fixes sbt#5369 Ref https://contributors.scala-lang.org/t/roadmap-for-the-tasty-reader-for-scala-2/4231 This implements support for inter-project dependencies between Scala 2.13 and Dotty, and vice versa. Scala 2.13 depending on Dotty would require 2.13.4 and above.
eed3si9n
force-pushed
the
wip/dotty-mixed
branch
from
854b5a7 to
f8139da
Compare
smarter
reviewed
Aug 17, 2020
| .withConfigurations(dep.configuration) | ||
| .withExplicitArtifacts(Vector.empty) | ||
| ) | ||
| else sys.error(s"scalaBinaryVersion mismatch: expected $sbv but found ${depSBV}") |
There was a problem hiding this comment.
Maybe the error could mention the names of the mismatched projects?
There was a problem hiding this comment.
The project name should show up as projectDependencies task failure, I think.
smarter
reviewed
Aug 17, 2020
|
|
||
| lazy val fooCore = (project in file("foo-core")) | ||
| .settings( | ||
| scalaVersion := scala213 |
There was a problem hiding this comment.
For completeness sake, I think it'd be nice to have one or more tests involving crossScalaVersion and running ++compile, e.g. what happens if I have a scala 3 app that depends on a lib that cross-compiles between 2 and 3, and vice-versa.
There was a problem hiding this comment.
That's probably not gonna work.
There was a problem hiding this comment.
Am I misreading previous @smarter comments? A 2.13.4+ (not released yet) should be able to depend on a dotty library, so why wouldn't this visa-versa test work?
There was a problem hiding this comment.
+ command is ignorant about the sandwich, so if there is a list of scalaVersions it wouldn't know how to align them. I'd much rather handle that scenario using sbt-projectmatrix - sbt/sbt-projectmatrix#28
There was a problem hiding this comment.
thanks for explaining! that makes sense!
eed3si9n
added a commit
to sbt/sbt-projectmatrix
that referenced
this pull request
Aug 23, 2020
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5369
Ref https://contributors.scala-lang.org/t/roadmap-for-the-tasty-reader-for-scala-2/4231
This implements support for inter-project dependencies between Scala 2.13 and Dotty, and vice versa. Scala 2.13 depending on Dotty would require 2.13.4 and above.