-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse pseudo selector arguments as declaration values #2120
Labels
enhancement
New feature or request
Comments
LibSass is also interested in the implementation of this. I've trying to clean up our selector handling. Our pseudo selector handling is need to some love. I'd take this change as an opportunity to bring our implementation closer to Ruby Sass'. |
nex3
added a commit
to sass/sass-spec
that referenced
this issue
Dec 19, 2016
This marks the spec as TODO for Ruby Sass.
nex3
added a commit
to sass/sass-spec
that referenced
this issue
Dec 19, 2016
This marks the spec as TODO for Ruby Sass.
nex3
added a commit
to sass/sass-spec
that referenced
this issue
Dec 19, 2016
This marks the spec as TODO for Ruby Sass.
nex3
added a commit
to sass/sass-spec
that referenced
this issue
Jun 3, 2017
nex3
added a commit
that referenced
this issue
Jun 3, 2017
nex3
added a commit
to sass/sass-spec
that referenced
this issue
Jun 3, 2017
nex3
added a commit
that referenced
this issue
Jun 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we have a bunch of custom logic to parse pseudo selector arguments. Although I think this covers all the syntaxes those selectors use in practice today, it's not very future-proof; CSS will probably add more different pseudo selector argument syntaxes in the future that may not fall under our current parsing. To be maximally future-proof, we should parse those arguments using the
<declaration-value>
production that was added to support custom properties. This will parse any sequence of reasonable characters while still respecting tokenization rules.The text was updated successfully, but these errors were encountered: