Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce commitlint #369

Merged
merged 16 commits into from
Apr 17, 2023
Merged

chore: introduce commitlint #369

merged 16 commits into from
Apr 17, 2023

Conversation

andrzejewsky
Copy link
Member

@andrzejewsky andrzejewsky commented Apr 12, 2023

This PR introduces - commitlint for linting commit messages. Based on conventional commits we are going to have automatically generated changelog.

@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 6:55am
macaw-ui-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 6:55am

@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 13:30 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 12, 2023 13:31 Inactive
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npx --no -- commitlint --edit ${1}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
npx --no -- commitlint --edit ${1}
pnpm dlx commitlint --edit ${1}

@@ -25,6 +25,14 @@ jobs:
version: 7.30
run_install: true

- name: Validate current commit (last commit)
if: github.event_name == 'push'
run: npx commitlint --from HEAD~1 --to HEAD --verbose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: npx commitlint --from HEAD~1 --to HEAD --verbose
run: pnpm dlx --from HEAD~1 --to HEAD --verbose


- name: Validate PR commits
if: github.event_name == 'pull_request'
run: npx commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: npx commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose
run: pnpm dlx --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose

@vercel vercel bot temporarily deployed to Preview – macaw-ui April 12, 2023 14:15 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 14:16 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 14:32 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 12, 2023 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 12, 2023 14:44 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 12, 2023 14:52 Inactive
@andrzejewsky andrzejewsky changed the title Introduce commitzen feat: Introduce commitzen Apr 12, 2023
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 15:09 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 12, 2023 15:11 Inactive
@krzysztofzuraw krzysztofzuraw changed the title feat: Introduce commitzen chore: introduce commitzen Apr 14, 2023
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 14, 2023 14:09 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 14, 2023 14:11 Inactive
@krzysztofzuraw krzysztofzuraw changed the title chore: introduce commitzen chore: introduce commitlint Apr 14, 2023
@krzysztofzuraw krzysztofzuraw marked this pull request as draft April 14, 2023 14:14
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 14, 2023 14:16 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 14, 2023 14:18 Inactive
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review April 17, 2023 06:52
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 17, 2023 06:53 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 17, 2023 06:55 Inactive
@krzysztofzuraw krzysztofzuraw marked this pull request as draft April 17, 2023 06:57
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review April 17, 2023 07:11
@krzysztofzuraw krzysztofzuraw merged commit cdd06a5 into canary Apr 17, 2023
@krzysztofzuraw krzysztofzuraw deleted the commitzen branch April 17, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants