Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storybook to v7 #357

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Update storybook to v7 #357

merged 2 commits into from
Apr 12, 2023

Conversation

andrzejewsky
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Apr 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
macaw-ui ❌ Failed (Inspect) Apr 12, 2023 10:24am
macaw-ui-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 10:24am

@andrzejewsky andrzejewsky requested review from krzysztofzuraw and poulch and removed request for krzysztofzuraw April 12, 2023 10:06
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 10:07 Inactive
krzysztofzuraw
krzysztofzuraw reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@krzysztofzuraw krzysztofzuraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - can you also check if removing those two lines from .npmrc works (I remember they were added because of storybook):

legacy-peer-deps=true
// TODO: #210 remove when upgrade storybook to v7
public-hoist-pattern[]=*storybook*

package.json Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – macaw-ui-next April 12, 2023 10:24 Inactive
@vercel vercel bot temporarily deployed to Preview – macaw-ui April 12, 2023 10:24 Inactive
@andrzejewsky andrzejewsky merged commit 910df37 into canary Apr 12, 2023
@andrzejewsky andrzejewsky deleted the storybook7 branch April 12, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poulch poulch poulch approved these changes

@krzysztofzuraw krzysztofzuraw krzysztofzuraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Dashboard
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrzejewsky @krzysztofzuraw @poulch