Text component #202
Merged
Text component #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poulch
approved these changes
Jan 11, 2023
andrzejewsky
approved these changes
Jan 12, 2023
src/components/Text/Text.tsx
Outdated
| type TextProps = TextVariants & { | ||
| children: React.ReactNode; | ||
| as?: "h1" | "h2" | "h3" | "h4" | "h5" | "h6" | "p" | "span"; | ||
| color?: "neutralTextPrimary"; |
There was a problem hiding this comment.
consider to type it instead of using string
krzysztofzuraw
force-pushed
the
195-theme-provider
branch
from
b9bd878
to
4381623
Compare
krzysztofzuraw
force-pushed
the
196-text-component
branch
from
903874a
to
2b05a2e
Compare
This was referenced Jan 12, 2023
Merged
Merged
This was referenced Jan 20, 2023
Merged
Merged
Merged
This was referenced Jan 27, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195
Added new
<Text>Lorem ipsum...</Text>component.