New repo structure #199
Merged
New repo structure #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poulch
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
LGTM, awesome job Kris 💪🏻
I have a couple of comments to consider:
pnpm run devdoesn't work- IMO
legacy/package.jsonshould be marked as private and should be cleaned as it will not be a source on package - I'd rather keep the package.json keep short and keep and move all config to separate files like prettier, release-it
- Should we have husky configure also for new package ?
This was referenced Jan 12, 2023
This was referenced Jan 18, 2023
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 26, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #194
What has been done?
legacyfolder and updated a pkg.json exportsrelease-itto publish to npm & GitHub releases. I think we can release a new macaw as8.0.0-0(prerelease) for time being - thanks to that we will have a proper tag on NPM (next) and on GitHub.