Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cargo-audit's binary_deps module public #1291

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TitusVM
Copy link

@TitusVM TitusVM commented Nov 21, 2024

See #1290
Exposed binary_deps module to the rustsec crate and made the file size limit configurable.

@Shnatsel
Copy link
Member

Shnatsel commented Nov 22, 2024

cargo audit does not provide a stable library interface, but the rustsec crate does. So the functions from binary_deps.rs should be moved to the rustsec crate, behind a binary-scanning Cargo feature.

Sorry if that wasn't clear from the start.

@TitusVM
Copy link
Author

TitusVM commented Nov 25, 2024

No problem! I misunderstood... I'm still an amateur contributor, so thank you for the explanation. I tried applying what you explained - I hope this is what you meant - otherwise please let me know!

The pipeline fails because there is a new vulnerability in rustls. What is the procedure in a case like this? AFAIK the package is only indirectly used by rustsec.

@Shnatsel
Copy link
Member

cargo update -p rustls should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants