Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to OS documentation, attempt 3 #319

Merged
merged 5 commits into from
Aug 13, 2022
Merged

Add links to OS documentation, attempt 3 #319

merged 5 commits into from
Aug 13, 2022

Conversation

Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw commented Jul 21, 2022 •
edited
Loading

Replaces #248.

This increases MSRV to 1.54 (released nearly a year ago).

@Thomasdezeeuw Thomasdezeeuw mentioned this pull request Jul 21, 2022
Closed
@Thomasdezeeuw Thomasdezeeuw force-pushed the man-link3 branch 3 times, most recently from 43b506d to d6a1c42 Compare July 21, 2022 16:37
@Darksonn
Copy link
Collaborator

I notice that you have an open tracking issue for a breaking release. Is the MSRV bump happening as part of a breaking release?

@carllerche
Copy link
Member

Socket2 bumping MSRV as an 0.x.0 release would be fine for us downstream (Tokio), but Tokio needs at a minimum 1.49.0 for socket2 0.4.x

@Thomasdezeeuw
Copy link
Collaborator Author

I notice that you have an open tracking issue for a breaking release. Is the MSRV bump happening as part of a breaking release?

It's a year old so I figure it's ok, but we can bump to 0.5.x.

Socket2 bumping MSRV as an 0.x.0 release would be fine for us downstream (Tokio), but Tokio needs at a minimum 1.49.0 for socket2 0.4.x

I though Tokio supported 6 months of Rust versions. Is this for a LTS release?

@carllerche
Copy link
Member

@Thomasdezeeuw yes, but we also don't break MSRV in patch releases. If socket2 breaks MSRV in a patch it will break at the very least our LTS which is pinned.

@Thomasdezeeuw
Copy link
Collaborator Author

I'll start the v0.5.x version and update rustc to 1.62 (has creation of unix::SocketAddr) or something.

@Thomasdezeeuw
Copy link
Collaborator Author

Created #320 for v0.5, I've updated the MSRV to 1.62, aiming to support 1.63 (for I/O safety).

@Thomasdezeeuw Thomasdezeeuw merged commit 6669064 into rust-lang:master Aug 13, 2022
@Thomasdezeeuw Thomasdezeeuw deleted the man-link3 branch August 13, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thomasdezeeuw @Darksonn @carllerche