Runtime Observable Settings #184
Conversation
|
Thanks! I'm traveling right now so I probably won't get a chance to review this closely for a week or so. I'm still not sure how I feel on the naming, but will probably merge it with what you have and change it before I put out a release with it. Speaking of the next release, I already have a 1.2 branch with some other pending updates. Do you think you can rebase against that branch? If not, I can do it when I'm back. I'm guessing the only major change needed will be the gradle files because I converted the old buildsrc code to use script plugins. |
|
To fix the CI failure, run the |
psuzn
force-pushed
the
sp/runtime-observable-settings
branch
from
109671d to
8da35e3
Compare
|
@russhwolf, any update on this? |
russhwolf
left a comment
russhwolf
left a comment
There was a problem hiding this comment.
Sorry to leave this sitting. I've had less time over the last couple weeks than I'd hoped. I plan to merge this soon and probably make a couple tweaks on top of it, but had a couple clarifying questions first.
multiplatform-settings-runtime-observable/src/commonMain/kotlin/Converter.kt
Outdated
Show resolved
Hide resolved
...rm-settings-runtime-observable/src/commonTest/kotlin/RuntimeObservableSettingsWrapperTest.kt
Outdated
Show resolved
Hide resolved
|
Thanks! |
2 participants
This adds support for the wrapper around the normal setting (#155 ) to make it runtime observable.
@russhwolf I have named it
runtime-observablebut we can rename it if there is a better name.I also have added the
checkObservableflag on the converter extension function, so one can just use theno-arginitializer and use the converter to make it observable. In some platforms, the instance returned byno-argis already observable; in that case, the converter doesn't add any wrapper.