feat: capture delayed events #4104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvrach
commented
Nov 9, 2023
lvrach
commented
Nov 9, 2023
…re.capture-delayed-events
lvrach
force-pushed
the
chore.capture-delayed-events
branch
from
e2448ee to
9513fd6
Compare
achettyiitr
reviewed
Nov 9, 2023
achettyiitr
reviewed
Nov 9, 2023
achettyiitr
approved these changes
Nov 9, 2023
achettyiitr
reviewed
Nov 9, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4104 +/- ##
==========================================
+ Coverage 72.44% 72.49% +0.04%
==========================================
Files 382 383 +1
Lines 55420 55476 +56
==========================================
+ Hits 40149 40216 +67
+ Misses 12940 12931 -9
+ Partials 2331 2329 -2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Akash Chetty <[email protected]>
…rudder-server into chore.capture-delayed-events
atzoum
reviewed
Nov 14, 2023
…re.capture-delayed-events
…rudder-server into chore.capture-delayed-events
…re.capture-delayed-events
atzoum
approved these changes
Nov 16, 2023
Comment on lines
+1619
to
+1626
| source, err := proc.getSourceBySourceID(string(sourceID)) | ||
| if err != nil { | ||
| continue | ||
| } | ||
|
|
||
| for _, obs := range proc.sourceObservers { | ||
| obs.ObserveSourceEvents(source, events) | ||
| } |
Contributor
There was a problem hiding this comment.
trivial: alternative with less lines
Suggested change
| source, err := proc.getSourceBySourceID(string(sourceID)) | |
| if err != nil { | |
| continue | |
| } | |
| for _, obs := range proc.sourceObservers { | |
| obs.ObserveSourceEvents(source, events) | |
| } | |
| if source, err := proc.getSourceBySourceID(string(sourceID)); err == nil { | |
| for _, obs := range proc.sourceObservers { | |
| obs.ObserveSourceEvents(source, events) | |
| } | |
| } |
Member
Author
There was a problem hiding this comment.
I find the usage of if ...; err == nil less readable. I am in favor of aligning the happy path to the left. https://medium.com/@matryer/line-of-sight-in-code-186dd7cdea88
Comment on lines
39
to
50
| sdkContext, err := misc.NestedMapLookup(event.Message, "context", "library") | ||
| if err == nil { | ||
| m, ok := sdkContext.(map[string]interface{}) | ||
| if ok { | ||
| sdkLibVersion, _ := m["version"].(string) | ||
| sdkLibName, _ := m["name"].(string) | ||
|
|
||
| if sdkLibName != "" || sdkLibVersion != "" { | ||
| sdkVersion = fmt.Sprintf("%s/%s", sdkLibName, sdkLibVersion) | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| sdkContext, err := misc.NestedMapLookup(event.Message, "context", "library") | |
| if err == nil { | |
| m, ok := sdkContext.(map[string]interface{}) | |
| if ok { | |
| sdkLibVersion, _ := m["version"].(string) | |
| sdkLibName, _ := m["name"].(string) | |
| if sdkLibName != "" || sdkLibVersion != "" { | |
| sdkVersion = fmt.Sprintf("%s/%s", sdkLibName, sdkLibVersion) | |
| } | |
| } | |
| } | |
| if sdkContext, err := misc.NestedMapLookup(event.Message, "context", "library"); err == nil { | |
| if m, ok := sdkContext.(map[string]interface{}); ok { | |
| sdkVersion = strings.Join([]string{m["version"].(string), m["name"].(string)}, "/") | |
| } | |
| } |
…re.capture-delayed-events
…rudder-server into chore.capture-delayed-events
…re.capture-delayed-events
This was referenced Dec 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WARNING: Requires rudderlabs/rudder-go-kit#210 to be merged first
Motivation
Gather statistics about delayed events. Events that are being delivered - usually due to retries - many days after their initial creation.
The intention is to gather stats, that can be used for decision making and further help investigation of deduplicate records.
Implementation
I created a separate
delayedpackage for encapsulation and testability.sourceObserverinterface provides a generic way to inspect events on the source level.Linear Ticket
Completes PIPE-516
Security