Skip to content

feat: generic consent management #4056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saikumarrs merged 93 commits into from
Dec 5, 2023
Merged

feat: generic consent management #4056

saikumarrs merged 93 commits into from
Dec 5, 2023

Conversation

@saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Oct 31, 2023 •
edited by coderabbitai bot
Loading

Description

Add support for generic consent management.

Linear Ticket

https://linear.app/rudderstack/issue/SDK-663/add-the-new-consent-managment-module-in-the-rudder-server

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Summary by CodeRabbit

  • New Features

    • Enhanced consent management logic with new data structures for improved handling of user consents.
    • Introduced new methods for retrieving consent data from various consent management providers.

  • Improvements

    • Updated existing consent filtering logic to support both legacy and new consent management systems.
    • Refined test functions to align with the updated consent management logic and added new test cases for comprehensive coverage.

  • Refactor

    • Renamed key functions to better reflect their purpose in the context of consent management.
    • Restructured test functions for improved clarity and maintainability.

  • Documentation

    • Corrected a typographical error in the code comments for better code documentation.

  • Bug Fixes

    • Adjusted function signatures and parameters to ensure consistency and correct handling of consent information.

@saikumarrs saikumarrs self-assigned this Oct 31, 2023
@saikumarrs saikumarrs requested a review from cisse21 October 31, 2023 14:07
@codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (6dbccb3) 72.75% compared to head (6232212) 72.84%.

Files Patch % Lines
processor/consent.go 93.33% 5 Missing and 2 partials ⚠️
processor/processor.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4056      +/-   ##
==========================================
+ Coverage   72.75%   72.84%   +0.09%     
==========================================
  Files         387      387              
  Lines       56266    56357      +91     
==========================================
+ Hits        40937    41056     +119     
+ Misses      12968    12953      -15     
+ Partials     2361     2348      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cisse21
cisse21 approved these changes Nov 1, 2023
View reviewed changes
cisse21
cisse21 requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@cisse21 cisse21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested few changes with regards to implementation. Also we can get all the consent related functions into a separate file which would make it easier to test

Sidddddarth
Sidddddarth reviewed Dec 4, 2023
View reviewed changes
achettyiitr
achettyiitr reviewed Dec 4, 2023
View reviewed changes
achettyiitr
achettyiitr reviewed Dec 4, 2023
View reviewed changes
achettyiitr
achettyiitr reviewed Dec 4, 2023
View reviewed changes
achettyiitr
achettyiitr reviewed Dec 4, 2023
View reviewed changes
achettyiitr
achettyiitr reviewed Dec 4, 2023
View reviewed changes
achettyiitr
achettyiitr reviewed Dec 4, 2023
View reviewed changes
@achettyiitr
Copy link
Member

achettyiitr commented Dec 4, 2023

Approving with minor comments left.

@saikumarrs saikumarrs merged commit 0f202e8 into master Dec 5, 2023
This was referenced Dec 5, 2023
Closed
Closed
Merged
Merged
@achettyiitr achettyiitr deleted the feat.generic-consent-management-sdk-663 branch January 12, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@cisse21 cisse21 cisse21 approved these changes

@achettyiitr achettyiitr achettyiitr approved these changes

@bardisg bardisg Awaiting requested review from bardisg

+1 more reviewer

@Sidddddarth Sidddddarth Sidddddarth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saikumarrs saikumarrs

Labels

Ready for Review server-team with tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saikumarrs @achettyiitr @cisse21 @Sidddddarth