Allow --host for yank/unyank command #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smellsblue can you resolve the merge conflicts? We've dropped |
Revert the other host code in the test Pass the host to rubygems_api_request (not sure why this fixes the test...)
smellsblue
force-pushed
the
yank-from-alternate-host
branch
from
274c944 to
45e1d9d
Compare
|
@indirect done :-) |
krainboltgreene
pushed a commit
that referenced
this pull request
Dec 31, 2015
Allow --host for yank/unyank command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
yank/unyankdoesn't have a--hostoption likepushdoes.It would be convenient to have such an option so someone running a private gem server can easily yank or unyank a gem using RubyGems.
It is already possible to do this via the
RUBYGEMS_HOSTenvironment variable, however I didn't even know this was possible until I saw it in the code.I tried to keep my change minimal, and the style as consistent as possible, but please let me know if I missed something, or you would like any additional changes or tests.