Windows: Set nonblock=true on pipes and non-datagram sockets #6897
+33
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables pipes, TCP and UNIXSocket for Fiber.scheduler. Nonblocking UDP doesn't work on Windows and is therefore excluded. This also adds tests to verify pipe, TCP and UDP messages.
This was referenced Dec 10, 2022
Member
Author
|
@larskanis should we take another go at this? |
Member
Author
|
@larskanis any chance we can work on this together? |
Contributor
|
@ioquatix Thanks for asking! Unfortunately l still have a ffi release pending and currently less time for OSS development. Not sure when I'll do Windows development again, as I don't like it that much. |
Member
Author
|
I also dislike Windows development haha :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables pipes, TCP and UNIXSocket for Fiber.scheduler. Nonblocking UDP doesn't work on Windows and is therefore excluded.
This also adds tests to verify pipe, TCP and UDP messages.