rename thread internal naming #5814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ko1
force-pushed
the
rename_gvl
branch
2 times, most recently
from
b71f3d4 to
bdefe25
Compare
Now GVL is not process *Global* so this patch try to use another words. * `rb_global_vm_lock_t` -> `struct rb_thread_sched` * `gvl->owner` -> `sched->running` * `gvl->waitq` -> `sched->readyq` * `rb_gvl_init` -> `rb_thread_sched_init` * `gvl_destroy` -> `rb_thread_sched_destroy` * `gvl_acquire` -> `thread_sched_to_running` # waiting -> ready -> running * `gvl_release` -> `thread_sched_to_waiting` # running -> waiting * `gvl_yield` -> `thread_sched_yield` * `GVL_UNLOCK_BEGIN` -> `THREAD_BLOCKING_BEGIN` * `GVL_UNLOCK_END` -> `THREAD_BLOCKING_END` * removed * `rb_ractor_gvl` * `rb_vm_gvl_destroy` (not used) There are GVL functions such as `rb_thread_call_without_gvl()` yet but I don't have good name to replace them. Maybe GVL stands for "Greate Valuable Lock" or something like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now GVL is not process Global so this patch try to use
another words.
rb_global_vm_lock_t->struct rb_thread_schedgvl->owner->sched->runninggvl->waitq->sched->readyqrb_gvl_init->rb_thread_sched_initgvl_destroy->rb_thread_sched_destroygvl_acquire->thread_sched_to_running# waiting -> ready -> runninggvl_release->thread_sched_to_waiting# running -> waitinggvl_yield->thread_sched_yieldGVL_UNLOCK_BEGIN->THREAD_BLOCKING_BEGINGVL_UNLOCK_END->THREAD_BLOCKING_ENDand
rb_ractor_gvlrb_vm_gvl_destroy(not used)There are GVL functions such as
rb_thread_call_without_gvl()yetbut I don't have good name to replace them. Maybe GVL stands for
"Greate Valuable Lock" or something like that.