YJIT: Fix SP index with optarg and unordered kwarg #5379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
requested review from
XrXr,
maximecb and
tenderlove
as code owners
eregon
reviewed
Dec 30, 2021
Previously when we were calling a method with an optional argument and multiple keywords arguments which weren't in the order the receiver expected we would use the wrong SP index to rearrange them. Fixes Bug #18453
jhawthorn
force-pushed
the
yjit_fix_kwarg_optarg_index
branch
from
9f79844 to
78fe451
Compare
XrXr
reviewed
Dec 31, 2021
Member
There was a problem hiding this comment.
Thanks for tracking this down. Sorry I didn't catch this when reviewing #5285. Now I really need to write a fuzzer to test this code. Others can approve this if they want, but I'm not comfortable doing so before I do some randomized property based testing. This is the fourth miscompilation bug from keyword args handling now. 1234
Footnotes
Member
Author
|
Trying a fuzzer/property based testing is a good idea. I'm going to merge as we know this fixes the current issue. |
noahgibbs
added a commit
to Shopify/ruby
that referenced
this pull request
Mar 7, 2022
noahgibbs
added a commit
to Shopify/ruby
that referenced
this pull request
Mar 7, 2022
maximecb
pushed a commit
to Shopify/ruby
that referenced
this pull request
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we were calling a method with an optional argument and multiple keywords arguments which weren't in the order the receiver expected we would use the wrong SP index to rearrange them.
Fixes Bug #18453