-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Require performance fix - code review #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
151224f
6f9a15d
2cb09a6
a3e3f01
86ed673
b20b293
42d8f82
c4b552f
d91179d
ac9498d
2bedcb9
301eaae
3e03f7f
5ae2a0e
e23f97e
460fb8f
88f9bab
eb8ee9a
41ed774
cb12cc2
d5567a3
da2f6b2
aba32cf
cffaa8e
d31fbb1
60aaf0b
de8b4e7
ee48900
cacd227
f19623d
d8a2bf6
e43847f
058323a
c442bce
e52a34b
752c955
3df711d
e3d72d6
8686576
8652090
0abe5a7
1c088c6
06aa81a
30b72cd
d7d6c41
4b6040b
49beb20
1b94e34
aca6251
315a20a
3304125
729caae
9158b2a
74bb0b6
b68d668
a60f97c
07fada2
9005515
5fe4248
93c4717
fcfa394
0757268
1f01734
21f7d11
58771f3
23724fc
6d6f204
6bd8bcb
11203f2
992c68c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -129,3 +129,4 @@ y.tab.c | |
|
|
||
| # /win32/ | ||
| /win32/*.ico | ||
| ext/win32ole/.document | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,8 +36,8 @@ | |
| $topdir = "." | ||
| $top_srcdir = srcdir | ||
|
|
||
| $" << "mkmf.rb" | ||
| load File.expand_path("lib/mkmf.rb", srcdir) | ||
| $:.unshift(srcdir + '/lib') | ||
| require 'mkmf' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are you intermixing personal idiom preferences with your perf enhancement or is this a substantive change?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Substantive. The old form doesn't make sense in the New World, since we only deal with expanded paths now and 'mkmf' is meaningless without a directory. I made the same change on Also, I believe the old form to be confusing and not required. I have asked on the ruby-core mailing list for clarification. |
||
| require 'optparse/shellwords' | ||
|
|
||
| def sysquote(x) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # This class is now defined entirely in enumerator.c and is always available. | ||
| # This file needs to remain here for backwards compatibility, so that `require | ||
| # "enumerator"` will not raise an exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you intermixing personal idiom preferences with your perf enhancement or is this a substantive change?