Skip to content

[3.4] compile.c: Handle anonymous variables in outer_variable_cmp #13493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k0kubun merged 3 commits into from
Sep 16, 2025
Merged

[3.4] compile.c: Handle anonymous variables in outer_variable_cmp #13493

k0kubun merged 3 commits into from
Sep 16, 2025

Conversation

@byroot
Copy link
Member

@byroot byroot commented Jun 2, 2025

@byroot byroot requested a review from k0kubun as a code owner June 2, 2025 13:00
@byroot byroot changed the title compile.c: Handle anonymous variables in outer_variable_cmp [3.4] compile.c: Handle anonymous variables in outer_variable_cmp Jun 2, 2025
@launchable-app

This comment has been minimized.

Sign in to view
@byroot
Copy link
Member Author

byroot commented Jun 2, 2025

Interesting. Somehow the fix no longer works once backported :/

No idea to fix that.

@hsbt hsbt added the Backport label Jun 25, 2025
@k0kubun k0kubun mentioned this pull request Sep 8, 2025
Closed
@rwstauner rwstauner mentioned this pull request Sep 16, 2025
Merged
@rwstauner
Copy link
Contributor

rwstauner commented Sep 16, 2025

I backported a different commit to fix the bug that this test was highlighting.
#14573

outer_variable_cmp isn't being run in the context of the test, but I don't know if your fix might still be wanted for some other reason (maybe there is another way to induce the crash?).

@k0kubun k0kubun merged commit 6882012 into ruby:ruby_3_4 Sep 16, 2025
75 checks passed
@k0kubun
Copy link
Member

k0kubun commented Sep 16, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k0kubun k0kubun Awaiting requested review from k0kubun k0kubun is a code owner

Assignees

No one assigned

Labels

Backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@byroot @rwstauner @k0kubun @hsbt