YJIT: End the block after OPTIMIZE_METHOD_TYPE_CALL #13245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XrXr
approved these changes
May 5, 2025
This was referenced May 5, 2025
matzbot
pushed a commit
that referenced
this pull request
May 24, 2025
YJIT: End the block after OPTIMIZE_METHOD_TYPE_CALL (#13245)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets
OPTIMIZE_METHOD_TYPE_CALLend the block at the instruction, which currently keeps compiling.If we don't end the block and it's followed by a setlocal in the same block, we can't invalidate the setlocal instruction properly when
OPTIMIZE_METHOD_TYPE_CALLescapes the EP.See also: #10487, which relies on #10539