Skip to content

Backport GH-12830 for Ruby 3.4 #12831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hsbt merged 1 commit into from
Feb 28, 2025
Merged

Backport GH-12830 for Ruby 3.4 #12831

hsbt merged 1 commit into from
Feb 28, 2025

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Feb 28, 2025

@hsbt
Visual Studio 2022 17.13.x couldn't build miniruby.exe. It prevents o…
54026ec 
…ther PRs.

actions/runner-images@e43209e

```
user32.lib advapi32.lib shell32.lib ws2_32.lib iphlpapi.lib gmp.lib imagehlp.lib shlwapi.lib bcrypt.lib
linking miniruby.exe
   Creating library miniruby.lib and object miniruby.exp
[BUG] heap_idx_for_size: allocation size too large (size=145u, heap_idx=25u)
ruby 3.5.0dev (2025-02-28T01:12:37Z pull/12827/merge 3d6a5a1) [x64-mswin64_140]
```

```
user32.lib advapi32.lib shell32.lib ws2_32.lib iphlpapi.lib imagehlp.lib shlwapi.lib bcrypt.lib
  linking miniruby.exe
  NMAKE : fatal error U1077: '@ miniruby.exe -v' : return code '0xc0000005'
```
@hsbt hsbt requested a review from k0kubun as a code owner February 28, 2025 06:52
@hsbt hsbt merged commit 7759263 into ruby:ruby_3_4 Feb 28, 2025
77 checks passed
@hsbt hsbt added the Backport label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k0kubun k0kubun Awaiting requested review from k0kubun k0kubun is a code owner

Assignees

No one assigned

Labels

Backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hsbt