Introduce rb_io_blocking_region which takes struct rb_io argument.
#11795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
io-blocking-region
branch
2 times, most recently
from
541be97 to
7060187
Compare
ioquatix
force-pushed
the
io-blocking-region
branch
from
7060187 to
fc18c68
Compare
ioquatix
force-pushed
the
io-blocking-region
branch
from
fc18c68 to
680951c
Compare
Member
Author
|
See #11796 for |
ioquatix
force-pushed
the
io-blocking-region
branch
from
e33cea0 to
b6f34ad
Compare
ioquatix
force-pushed
the
io-blocking-region
branch
from
b6f34ad to
30a66fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for changes to
struct rb_io. Instead of passingfd, we should pass thestruct rb_io, so that we have access to all the internals. This does not change any visible behaviour, but funnels all calls torb_thread_io_blocking_regionvia this interface, which can be later modified to handleIO#closemore effectively.I will do a few parts of the core conversion in this PR, and then follow up with separate PRs for
ext/socketetc.See the previous work #5384 for more details.