Support ::
prefixed constants on some cops
#868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the following Pull Request was merged, I checked to see if any other cop has a similar problem.
::Rails
and::File
onRails/FilePath
cop #865As a result, I found those problems in the following cops, so I created this Pull Request.
Rails/ActionControllerFlashBeforeRender
Rails/ActionControllerTestCase
Rails/ApplicationController
Rails/ApplicationJob
Rails/ApplicationMailer
Rails/ApplicationRecord
Rails/DotSeparatedKeys
Rails/DynamicFindBy
Rails/FindEach
Rails/FreezeTime
Rails/HasManyOrHasOneDependent
Rails/HelperInstanceVariable
Rails/MailerName
Rails/MigrationClassName
Rails/Output
Rails/ReversibleMigrationMethodDefinition
Rails/ReversibleMigration
Rails/ShortI18n
Rails/SkipsModelValidations
Rails/TimeZoneAssignment
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.