Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support :: prefixed constants on some cops #868

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Nov 15, 2022

After the following Pull Request was merged, I checked to see if any other cop has a similar problem.

As a result, I found those problems in the following cops, so I created this Pull Request.

  • Rails/ActionControllerFlashBeforeRender
  • Rails/ActionControllerTestCase
  • Rails/ApplicationController
  • Rails/ApplicationJob
  • Rails/ApplicationMailer
  • Rails/ApplicationRecord
  • Rails/DotSeparatedKeys
  • Rails/DynamicFindBy
  • Rails/FindEach
  • Rails/FreezeTime
  • Rails/HasManyOrHasOneDependent
  • Rails/HelperInstanceVariable
  • Rails/MailerName
  • Rails/MigrationClassName
  • Rails/Output
  • Rails/ReversibleMigrationMethodDefinition
  • Rails/ReversibleMigration
  • Rails/ShortI18n
  • Rails/SkipsModelValidations
  • Rails/TimeZoneAssignment

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit 2a07001 into rubocop:master Nov 19, 2022
@koic
Copy link
Member

koic commented Nov 19, 2022

Great 👍 Thank you!

@r7kamura r7kamura deleted the feature/add-cbase-support branch November 20, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants