Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative for Rails/ActionControllerTestCase when class is namespaced #824

Closed
wants to merge 1 commit into from

Conversation

vlad-pisanov
Copy link
Contributor

Consider

class MyControllerTest1 < ActionController::TestCase
end

class Foo::Bar::MyControllerTest2 < ActionController::TestCase
end

Currently, Rails/ActionControllerTestCase flags the first class as an offence, but not the second one because it is namespaced. This PR addresses that problem.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic
Copy link
Member

koic commented Jan 2, 2023

@vlad-pisanov This looks good to me. Can you rebase with the latest master branch?

@koic
Copy link
Member

koic commented Feb 25, 2023

I will close this PR because this patch has been cherry-picked in the master branch. Thank you.
c532db1

@koic koic closed this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants