Fix a false-positive with Rails/RelativeDateConstant #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdelStrother
force-pushed
the
relative-date
branch
from
e318801 to
ae93cb6
Compare
|
nvm, it's fine 😛 |
koic
reviewed
May 11, 2021
Prior to this, procs would only be allowed for the top-level assignment
- eg
FOO = 1.week.ago # bad
FOO = Proc.new { 1.week.ago } # good
but didn't accept cases where the Proc was nested further down, eg:
FOO = {
weekly: Proc.new { 1.week.ago } # bad (but should be good!)
}
This patch changes the RelativeDateConstant to recursive down through
the child nodes of the const-assignment, stopping whenever a Proc is
encountered.
As a result, ranges no longer need special-casing, so I've removed the
handling for those.
jdelStrother
force-pushed
the
relative-date
branch
from
ae93cb6 to
e0e1c9a
Compare
|
Thanks, done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, procs would only be allowed for the top-level assignment - eg
but didn't accept cases where the Proc was nested further down, eg:
This patch changes the RelativeDateConstant to recursive down through
the child nodes of the const-assignment, stopping whenever a Proc is
encountered.
As a result, ranges no longer need special-casing, so I've removed the
handling for those.