Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Rails/Pick cop #249

Merged
merged 1 commit into from
May 27, 2020
Merged

Add new Rails/Pick cop #249

merged 1 commit into from
May 27, 2020

Conversation

eugeneius
Copy link
Contributor

pick(...) is a shorthand for pluck(...).first.

https://api.rubyonrails.org/classes/ActiveRecord/Calculations.html#method-i-pick

This cop is unsafe because pluck is defined on both ActiveRecord::Relation and Enumerable, whereas pick is only defined on ActiveRecord::Relation in Rails 6.0. This will be addressed in Rails 6.1 via rails/rails#38760, at which point the cop will be safe. I don't know if there's currently a way to apply a different default configuration based on the Rails version, but I'd be happy to investigate that once Rails 6.1 is released.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

`pick(...)` is a shorthand for `pluck(...).first`.
@koic koic merged commit 73281e1 into rubocop:master May 27, 2020
@koic
Copy link
Member

koic commented May 27, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants