Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Rails/WhereExists with EnforcedStyle: where and implicit recievers #1241

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Earlopain
Copy link
Contributor

EnforcedStyle: exists works fine, but since there was no test for this I added one.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@Earlopain Earlopain force-pushed the fix-error-for-where-exists branch from 4c5065a to 80beaf2 Compare February 26, 2024 11:18
@koic koic merged commit 3064122 into rubocop:master Feb 26, 2024
13 checks passed
@koic
Copy link
Member

koic commented Feb 26, 2024

Thanks!

@Earlopain Earlopain deleted the fix-error-for-where-exists branch February 26, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants