Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with / #1049

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Jul 19, 2023

This PR is fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /.

Auto-correct of following code would change the path.

Code to reproduce:

File.join(Rails.root, '/app/models', 'user.rb')

Expected behavior:

Rails.root.join("app/models/user.rb").to_s
# => "/rails/root/path/app/models/user.rb"

Actual behavior:

Rails.root.join("/app/models/user.rb").to_s
# => "/app/models/user.rb"

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • [-] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@ydah ydah force-pushed the fix-rails-file-path-autocorrect branch from 64c4904 to 914d9bc Compare July 19, 2023 12:08
@ydah ydah force-pushed the fix-rails-file-path-autocorrect branch from 3c5254c to 3b60cb8 Compare July 20, 2023 03:42
@koic koic merged commit ca58580 into rubocop:master Jul 21, 2023
@koic
Copy link
Member

koic commented Jul 21, 2023

Thanks!

@ydah ydah deleted the fix-rails-file-path-autocorrect branch July 24, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants