Fix an error for Rails/UniqueValidationWithoutIndex
#1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
reviewed
Jun 19, 2023
Comment on lines
79
to
80
| validates :account, presence: true | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Uniqueness validation should have a unique index on the database column. |
There was a problem hiding this comment.
Should this really register an offense in this case? Doesn't make sense in my opinion, since there is no uniqueness requirement on the field?
There was a problem hiding this comment.
I also think this should not raise an error.
Think about this example:
class Post
belongs_to :user
validates :user, presence: true
end
class User
has_many :posts
end
The column user_id in posts can NEVER be unique because a user can have many posts.
There was a problem hiding this comment.
Thank you for the comments. This is a bug and I'm working now.
This was referenced Jun 19, 2023
|
Ah, #1021 correction was not good enough. Maybe, it should have been as follows. - return if uniqueness_part(node)&.falsey_literal?
+ return unless uniqueness_part = uniqueness_part(node)
+ return if uniqueness_part.falsey_literal? |
koic
force-pushed
the
fix_an_error_for_rails_unique_validation_without_index
branch
4 times, most recently
from
418a64f to
b97ee12
Compare
Resolves rubocop#1022 (comment). This PR fixes an error for `Rails/UniqueValidationWithoutIndex` when the `presence: true` option is used alone for the `validates` method.
koic
force-pushed
the
fix_an_error_for_rails_unique_validation_without_index
branch
from
b97ee12 to
26dce91
Compare
|
Tested this PR against our codebase, and it fixed the problem for us. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1022 (comment).
This PR fixes an error for
Rails/UniqueValidationWithoutIndexwhen thepresence: trueoption is used alone for thevalidatesmethod.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.