Fix Rails/UniquenessValidationWithoutIndex
false positive on explicit disable
#1008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Rails/UniqueValidationWithoutIndex
Currently
validates :column_name, uniqueness: false
will report an offence if the schema does not specify a unique index for the corresponding database column. The cop is currently insensitive to the value of the:uniqueness
option. Any value (including falsyfalse
andnil
) will cause this cop to expect a unique index in the schema.This pull request fixes this behaviour such that we will now only report offences when the value of the
:uniqueness
option is truthy.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.