-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails/HttpPositionalArguments does not respect Rack::Test::Methods #99
Labels
bug
Something isn't working
Comments
jcraigk
changed the title
Rails/HttpPositionalArguments does not recognize include Rack::Test::Methods
Rails/HttpPositionalArguments does not respect Rack::Test::Methods
Aug 6, 2019
any update on it? |
What version of rack-test are you using?, version 0.7.0 require |
I'm currently seeing the issue with |
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Apr 1, 2023
…nts` Fixes rubocop#99. This PR fixes a false positive for `Rails/HttpPositionalArguments` when using `include Rack::Test::Methods`.
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Apr 1, 2023
…nts` Fixes rubocop#99. This PR fixes a false positive for `Rails/HttpPositionalArguments` when using `include Rack::Test::Methods`.
9 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Apr 1, 2023
…nts` Fixes rubocop#99. This PR fixes a false positive for `Rails/HttpPositionalArguments` when using `include Rack::Test::Methods`.
koic
added a commit
that referenced
this issue
Apr 2, 2023
…_positional_arguments [Fix #99] Fix a false positive for `Rails/HttpPositionalArguments`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rubocop/rubocop#7095 Expected behavior
In RSpec tests that use
Rack::Test::Methods
, theRails/HttpPositionalArguments
cop should not warn about using keyword arguments, as that is not how theRack::Test::Methods
work.Actual behavior
In RSpec tests that include the line
include Rack::Test::Methods
and then use theget
,post
, etc methods supplied in that module, theRails/HttpPositionalArguments
mistakenly warns that keyword arguments should be used. However, theRack::Test::Methods
do not support keyword arguments.From the Rubocop docs:
Steps to reproduce the problem
Run the
Rails/HttpPositionalArguments
on an RSpec file that includes the lineinclude Rack::Test::Methods
and then usesget
with at least one parameter.RuboCop version
Tangentially related to rubocop/rubocop#3629
The text was updated successfully, but these errors were encountered: