Skip to content

Conversation

@koic
Copy link
Member

@koic koic commented Dec 8, 2021

This PR fixes an incorrect autocorrect for Performance/MapCompact when using map.compact.first and there is a line break after map.compact and receiver.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes an incorrect autocorrect for `Performance/MapCompact`
when using `map.compact.first` and there is a line break after
`map.compact` and receiver.
@koic koic merged commit b9c1f05 into rubocop:master Dec 10, 2021
@koic koic deleted the fix_incorrect_autocorrect_for_performance_map_compact branch December 10, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant