Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Style/RedundantEqualityComparisonBlock #224

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 14, 2021

This PR fixes a false positive for Style/RedundantEqualityComparisonBlock when using one argument with comma separator in block argument.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR fixes a false positive for `Style/RedundantEqualityComparisonBlock`
when using one argument with comma separator in block argument.
@koic koic merged commit 2d6b745 into rubocop:master Mar 15, 2021
@koic koic deleted the fix_false_positive_for_redundant_equality_comparison branch March 15, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant