Skip to content

Conversation

@eugeneius
Copy link
Contributor

See #170 (comment).

When map is passed a block argument and sum is passed an initial value, they need to be combined in the new sum call's argument list.

I don't think a changelog entry is necessary since this correction hasn't been released yet.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

When `map` is passed a block argument and `sum` is passed an initial
value, they need to be combined in the new `sum` call's argument list.
@koic koic merged commit 63c1efb into rubocop:master Sep 22, 2020
@koic
Copy link
Member

koic commented Sep 22, 2020

Thank you for following up!

@eugeneius
Copy link
Contributor Author

You're welcome @koic! Thank you for all of your recent reviews. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants