Skip to content

Add new Performance/Squeeze cop #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koic merged 1 commit into from
Jun 8, 2020
Merged

Add new Performance/Squeeze cop #124

koic merged 1 commit into from
Jun 8, 2020

Conversation

@fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Jun 3, 2020

This cop will detect places where gsubing of multiple runs of single character by single character can be replaced by squeeze method.

# bad
str.gsub(/a+/, 'a')
str.gsub(/\\+/, '\\')
str.gsub!(/ +/, ' ')

# good
str.squeeze('a')
str.squeeze('\\')
str.squeeze!(' ')

Reference - https://github.com/JuanitoFatas/fast-ruby#remove-extra-spaces-or-other-contiguous-characters-code

koic
koic reviewed Jun 8, 2020
View reviewed changes
@fatkodima
Copy link
Contributor Author

fatkodima commented Jun 8, 2020

Updated.

@koic koic merged commit ee9d70c into rubocop:master Jun 8, 2020
@koic
Copy link
Member

koic commented Jun 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koic koic koic left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fatkodima @koic