Merge pull request #13179 from Earlopain/node-matcher-directiry-error

Fix an error for `InternalAffairs/NodeMatcherDirective` when no second argument
rubocop · Sep 2, 2024 · 9a38b11 · 9a38b11
2 parents 4bb7cba + fd4f4d7
commit 9a38b11
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb b/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb
@@ -45,7 +45,7 @@ class NodeMatcherDirective < Base
         PATTERN
 
         def on_send(node)
-          return if node.arguments.none?
+          return unless node.arguments.count == 2
           return unless valid_method_name?(node)
 
           actual_name = node.first_argument.value.to_s

diff --git a/spec/rubocop/cop/internal_affairs/node_matcher_directive_spec.rb b/spec/rubocop/cop/internal_affairs/node_matcher_directive_spec.rb
@@ -293,6 +293,12 @@ class MyCop
       RUBY
     end
 
+    it 'registers no offense without second argument' do
+      expect_no_offenses(<<~RUBY)
+        #{method} :foo?
+      RUBY
+    end
+
     context 'when using class methods' do
       it 'registers an offense when the directive is missing' do
         expect_offense(<<~RUBY, method: method)