[Fix #12638] Fix an Errno::ENOENT error when using server mode

Fixes #12638. There is a possibility of a race condition occurring with the status file when using server mode. The status file is updated to a new status by `Cache.write_status_file` (`Pathname#write`), so there is no need to clear it by deleting the file. Due to the difficulty in reproducing this race conditions, test code for this have not been added.
rubocop · Jan 22, 2024 · 60a9350 · 60a9350
1 parent 96542aa
commit 60a9350
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 2 deletions.
diff --git a/changelog/fix_an_error_when_using_sever_mode.md b/changelog/fix_an_error_when_using_sever_mode.md
@@ -0,0 +1 @@
+* [#12638](https://github.com/rubocop/rubocop/issues/12638): Fix an `Errno::ENOENT` error when using server mode. ([@koic][])
diff --git a/lib/rubocop/server/client_command/exec.rb b/lib/rubocop/server/client_command/exec.rb
@@ -17,7 +17,6 @@ module ClientCommand
       class Exec < Base
         def run
           ensure_server!
-          Cache.status_path.delete if Cache.status_path.file?
           read_stdin = ARGV.include?('-s') || ARGV.include?('--stdin')
           send_request(
             command: 'exec',

diff --git a/lib/rubocop/server/server_command/exec.rb b/lib/rubocop/server/server_command/exec.rb
@@ -16,7 +16,6 @@ module ServerCommand
       # @api private
       class Exec < Base
         def run
-          Cache.status_path.delete if Cache.status_path.file?
           # RuboCop output is colorized by default where there is a TTY.
           # We must pass the --color option to preserve this behavior.
           @args.unshift('--color') unless %w[--color --no-color].any? { |f| @args.include?(f) }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#12638](https://github.com/rubocop/rubocop/issues/12638): Fix an `Errno::ENOENT` error when using server mode. ([@koic][])