SAGE Journals #181
Merged
SAGE Journals #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
reviewed
Jul 11, 2018
|
Sorry that I didn't write in the first place that I would do it after you took a look. I sent the email just now. |
|
@yihui Contributor agreement is signed. |
yihui
requested changes
Jul 12, 2018
NEWS
Outdated
| @@ -1,6 +1,8 @@ | |||
| rticles 0.5 | |||
| --------------------------------------------------------------------- | |||
|
|
|||
| - Added the template for the SAGE Journals (thanks, @oguzhanogreden). | |||
DESCRIPTION
Outdated
| @@ -26,7 +26,8 @@ Authors@R: c( | |||
| person("Alessandro", "Gasparini", role = c("aut", "cph"), email = "[email protected]"), | |||
| person("Marc-Andre", "Desautels", role = c("aut", "cph"), email = "[email protected]"), | |||
| person("Dominik", "Leutnant", role = c("aut", "cph"), email = "[email protected]"), | |||
| person(family = "MDPI", role = c("aut", "cph")) | |||
| person(family = "MDPI", role = c("aut", "cph")), | |||
| person("Oğuzhan", "Öğreden", role = c("ctb"), comment = c(ORCID = "0000-0002-9949-3348")) | |||
There was a problem hiding this comment.
Feel free to make yourself aut instead of ctb if you want.
|
Done. Please note that I used |
yihui
approved these changes
Jul 12, 2018
yihui
added a commit
that referenced
this pull request
Jul 12, 2018
yihui
added a commit
that referenced
this pull request
Jul 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the SAGE journals.
Let me know if there's anything further to do!