Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeerJ format #127

Merged
merged 5 commits into from
Jun 29, 2017
Merged

PeerJ format #127

merged 5 commits into from
Jun 29, 2017

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Jun 27, 2017

Hello,

This is my submission for the PeerJ format. It currently has an issue with the placement of the "References" header, but other than that, everything should be cromulent.

I modified the template from Overleaf: https://www.overleaf.com/latex/templates/latex-template-for-peerj-journal-and-pre-print-submissions/ptdwfrqxqzbn

I've also included pandoc-style cross-references (e.g. \@ref(tab:table1)), which requires the users to use bookdown::pdf_document2(), which I've documented in the help and the skeleton. Otherwise, they can switch back to using \ref{} with the standard latex tables and figures.

@jjallaire
Copy link
Member

Looks good!

@jjallaire jjallaire merged commit 717c4d9 into rstudio:master Jun 29, 2017
@jjallaire
Copy link
Member

Could you open a new PR to add this to the package tests? If convenient it would also be great if you could run the test on Windows, OS X, and Linux and confirm it passes.

@zkamvar
Copy link
Contributor Author

zkamvar commented Jul 2, 2017

Hi! I just realized that I had muted this repo at some point in the past and didn't see this until now.
The version you pulled in should have the tests: https://github.com/rstudio/rticles/pull/127/files#diff-4f8540d05c0675b39d119ee57b3511d4

I have tested this on OSX and am in the process of testing it on Windows

@jjallaire
Copy link
Member

Okay, great. Let me know if tests pass on Windows then I'll merge.

@zkamvar
Copy link
Contributor Author

zkamvar commented Jul 2, 2017

It appears to work on windows as well.

@jjallaire
Copy link
Member

Great, thanks!

@dlebauer dlebauer mentioned this pull request Jan 23, 2018
Closed
yihui added a commit that referenced this pull request Mar 14, 2019
@yihui
remove the base_format argument from peerj_article() (#127) and `…
24d069f 
…copernicus_article()` (#172)
@yihui
Copy link
Member

yihui commented Mar 14, 2019

@zkamvar Please note that I just removed the base_format argument, since I noticed that people started doing this in other output formats following this format (e.g., #208 #172), which is really not necessary. To make use of bookdown's features, now you need to use:

output:
  bookdown::pdf_book:
    base_format: rticles::peerj_article

This way, we don't have to patch every single format in this package to support bookdown's features.

Thanks!

@yihui yihui mentioned this pull request Mar 14, 2019
Closed
@yihui yihui mentioned this pull request Jul 5, 2019
Closed
@yihui yihui mentioned this pull request Jul 14, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zkamvar @jjallaire @yihui