Skip to content

Update Onnxruntime version and fix Windows compilerconfig#565

Merged
royshil merged 5 commits intomainfrom
roy.bump_onnxruntime_1_17_1
Mar 20, 2024
Merged

Update Onnxruntime version and fix Windows compilerconfig#565
royshil merged 5 commits intomainfrom
roy.bump_onnxruntime_1_17_1

Conversation

@royshil
Copy link
Owner

@royshil royshil commented Mar 19, 2024

No description provided.

@royshil
Copy link
Owner Author

royshil commented Mar 20, 2024

@umireon we have a problem with onnxruntime 1.17.1 on linux where the .tgz file doesn't have the include/tensorrt_provider_factory.h
in v1.16.3 it did exist
i wonder if this file is no longer needed but TensorRT support still remains. it seems so because the .so file for tensorrt EP indeed exists in v1.17.1

@umireon
Copy link
Collaborator

umireon commented Mar 20, 2024

@royshil SessionOptionsAppendExecutionProvider_TensorRT and SessionOptionsAppendExecutionProvider_TensorRT_V2 got to be included in onnxruntime_c_api.h so that we can safely remove the inclusion of include/tensorrt_provider_factory.h without any changes.

@royshil
Copy link
Owner Author

royshil commented Mar 20, 2024

@umireon the build is good - do you want to test or approve? thanks!

@royshil royshil requested a review from umireon March 20, 2024 14:45
@royshil royshil merged commit cf5afb0 into main Mar 20, 2024
@royshil royshil deleted the roy.bump_onnxruntime_1_17_1 branch March 20, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants