Removed boost signals from CMakeLists.txt #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With boost=>1.69 there `signals` isn't available anymore. As it's not necessary, it should be removed to be compatible to all boost versions.
|
@jonbinney if you could take a look at this it would be much appreciated! |
Contributor
|
@acxz thanks for the reminder! I tried this out and it doesn't break anything. @bionade24 thank you! |
Author
|
When can we expect a new release of this repo? |
Contributor
|
@bionade24 what ros distro are you using? |
Author
|
I'm maintaining the melodic AUR packages. |
Contributor
|
Let me try doing a melodic release now |
Author
|
Thanks |
Contributor
|
I just released version 1.7.7 of laser_asembler and version 1.8.7 of laser_assembler into melodic. |
Author
|
Thanks! No I can remove the patches out of the packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With boost=>1.69 there
signalsisn't available anymore. As it's not necessary, it should be removed to be compatible to all boost versions.Same issue here: ros/ros_comm#1580