-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check types in typescript packages in CI #780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "check" or "typecheck" would be a better script name
Hi @NotWoods, after a bit more thought I asked some question about this approach here #779 (comment)
I don't think the |
So I know that historically we've had the the In the case of plugins which are already switched over to TypeScript sources, we should probably be generating the definitions at build time, and then removing the additional type check tests (as you point out, it'd be unnecessary). If we do that, for any plugin which uses generated definitions rather than the hand-written definition, we'll have to do a separate PR for each plugin. |
Co-authored-by: Tiger Oakes <[email protected]>
Ok, sounds good @shellscape. But for the scope of this PR I managed to deliver the type checking by checking all the ts files in each package, not just the @NotWoods I've merged your proposed change. |
Rollup Plugin Name:
alias, auto-install, data-url, eslint, html, pluginutils, typescript, virtual, wasm
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
fixes #779
Description
Have early feedback in every PR that typescript types are not compromised.
Add task test:ts to every plugin written in typescript
Run test:ts on circle ci config