Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 20, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title. Also split all-in-one and ordinary binaries into two crates, so that switching between modes won't cause rebuild.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1999 (1d7aaac) into main (63f4dd3) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1999      +/-   ##
==========================================
- Coverage   71.01%   70.90%   -0.12%     
==========================================
  Files         625      625              
  Lines       80532    80660     +128     
==========================================
+ Hits        57193    57195       +2     
- Misses      23339    23465     +126     
Flag Coverage Δ
rust 70.90% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd/src/bin/compute_node.rs 16.66% <ø> (ø)
src/cmd/src/bin/ctl.rs 16.66% <ø> (ø)
src/cmd/src/bin/frontend_node.rs 16.66% <ø> (ø)
src/cmd/src/bin/meta_node.rs 16.66% <ø> (ø)
src/cmd_all/src/bin/risingwave.rs 1.53% <0.00%> (ø)
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.88%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh enabled auto-merge (squash) April 20, 2022 14:00
@skyzh skyzh merged commit ffc46fc into main Apr 20, 2022
@skyzh skyzh deleted the skyzh/faster-build branch April 20, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants