chore(docs): instructions to check-in PRs from forks #1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <[email protected]>
liurenjie1024
approved these changes
Apr 11, 2022
Signed-off-by: Alex Chi <[email protected]>
TennyZhuang
approved these changes
Apr 11, 2022
Signed-off-by: Alex Chi <[email protected]>
BugenZhao
reviewed
Apr 11, 2022
|
|
||
| ``` | ||
| gh pr checkout <PR id> | ||
| git checkout -b forks/<PR id> |
There was a problem hiding this comment.
Suggested change
| git checkout -b forks/<PR id> | |
| git switch -c forks/<PR id> |
There was a problem hiding this comment.
I'd prefer to keep the working tree clean before doing the switch 🤪
neverchanje
approved these changes
Apr 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
- Coverage 71.30% 71.29% -0.01%
==========================================
Files 599 599
Lines 77672 77673 +1
==========================================
- Hits 55384 55377 -7
- Misses 22288 22296 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi [email protected]
What's changed and what's your intention?
As title. Also add a
broker-idoption for Kafka.Checklist
Refer to a related PR or issue link (optional)