feat(session-config): introduce entry-level pure in-memory set configuration #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenXiao1999
force-pushed
the
bw/add-session-flag
branch
from
5af2d5b to
bedf275
Compare
BowenXiao1999
changed the title
BowenXiao1999
force-pushed
the
bw/add-session-flag
branch
2 times, most recently
from
2498747 to
f10efc8
Compare
BugenZhao
reviewed
Apr 8, 2022
|
|
BowenXiao1999
force-pushed
the
bw/add-session-flag
branch
from
f10efc8 to
640c06e
Compare
skyzh
approved these changes
Apr 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1714 +/- ##
==========================================
- Coverage 71.17% 71.14% -0.03%
==========================================
Files 600 601 +1
Lines 77743 77795 +52
==========================================
+ Hits 55333 55347 +14
- Misses 22410 22448 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BowenXiao1999
force-pushed
the
bw/add-session-flag
branch
from
4515896 to
ded75a1
Compare
liurenjie1024
previously approved these changes
Apr 11, 2022
src/frontend/src/session.rs
Outdated
Contributor
There was a problem hiding this comment.
It's better to be an enum.
Contributor
Author
There was a problem hiding this comment.
Think twice and I still suggest not do this now. If we change to enum or introduce registry, it might be hard to design a good API (I guess have to use generics). May add a lot of efforts on this PR. For now, we'd better not bothering too much on user's invalid input and redcue the complexity.
src/frontend/src/session.rs
Outdated
Contributor
There was a problem hiding this comment.
We also need a registry to ban invalid config.
BowenXiao1999
force-pushed
the
bw/add-session-flag
branch
from
ded75a1 to
73eb6da
Compare
liurenjie1024
approved these changes
Apr 11, 2022
BowenXiao1999
force-pushed
the
bw/add-session-flag
branch
from
73eb6da to
14261dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Note this is just a simple beginning of support set comand. There are still a lot of todos: better config init policy, how to handle system level config/consistency of change config, how to persist config, better API design (Builder code patterns or possible generic to make the code pretty). I'd like to distribute the tasks to anyone who are interested in the project. Java's design looks good:
https://github.com/singularity-data/risingwave/blob/8a7c9718dc97eaaede84c1be5a107944a69835e1/legacy/common/src/main/java/com/risingwave/common/config/ConfigEntry.java#L11-L27
But I do not found properly crates to help me and a little overdesign (This part of java code is hard to translate to Rust), so I leave it simple.
The main goal is to remove annoying RW_IMPLICIT_FLUSH in start risedev. Design a
RwLock<HashMap<String, ConfigEntry>>(RwLook from parking_lot, not sure whether it is good, needs investigate) to store config flags, now all type of config values are stored as Stirng (e.g. "1", "true", "on"). For init, we will constructthe map manually inbuild_config_map().Checklist
Refer to a related PR or issue link (optional)