Skip to content

Conversation

@hengm3467
Copy link
Contributor

@hengm3467 hengm3467 commented Apr 8, 2022

What's changed and what's your intention?

Minor updates to the documentation section in readme & minor adjustments to the CONTRIBUTING.md

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    Clarified the purposes of user docs and developer docs, and slight adjustments to the starting section (and various headings) in CONTRIBUTING.md

  • How does this PR work? Need a brief introduction for the changed logic (optional)

  • Describe clearly one logical change and avoid lazy messages (optional)

  • Describe any limitations of the current code (optional)

Checklist

  • [ x] I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@neverchanje neverchanje changed the title Minor doc updates doc: Minor doc updates Apr 8, 2022
@github-actions github-actions bot added the A-doc Area: Documentation. label Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1688 (97c721d) into main (32bc057) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1688   +/-   ##
=========================================
  Coverage     69.43%   69.43%           
  Complexity     2766     2766           
=========================================
  Files          1058     1058           
  Lines         93393    93393           
  Branches       1790     1790           
=========================================
+ Hits          64849    64852    +3     
+ Misses        27653    27650    -3     
  Partials        891      891           
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.16% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.40% <0.00%> (+0.27%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh enabled auto-merge (squash) April 8, 2022 06:04
@hengm3467 hengm3467 removed the request for review from yingjunwu April 8, 2022 06:42
@skyzh skyzh merged commit 1c52e1f into main Apr 8, 2022
@skyzh skyzh deleted the hengm_doc_updates branch April 8, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-doc Area: Documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants