Skip to content

chore(doc): fix the FLUSH in cluster start up. #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Apr 7, 2022

What's changed and what's your intention?

Otherwise below e2e test will fail.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to create an issue. We should set such parameter using set instead of env variable eventually.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1657 (50a788b) into main (824b7d2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1657   +/-   ##
=========================================
  Coverage     69.79%   69.79%           
  Complexity     2766     2766           
=========================================
  Files          1050     1050           
  Lines         92481    92481           
  Branches       1790     1790           
=========================================
+ Hits          64546    64548    +2     
+ Misses        27044    27042    -2     
  Partials        891      891           
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/manager/stream_clients.rs 96.29% <0.00%> (+7.40%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BowenXiao1999
Copy link
Contributor Author

Better to create an issue. We should set such parameter using set instead of env variable eventually.

Already have. see #1219

@BowenXiao1999 BowenXiao1999 merged commit 3d4e799 into main Apr 7, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw/fix-e2e-guide branch April 7, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants