chore(doc): psql not need the db name #1651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
approved these changes
Apr 7, 2022
TennyZhuang
approved these changes
Apr 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #1651 +/- ##
============================================
- Coverage 69.79% 69.79% -0.01%
Complexity 2766 2766
============================================
Files 1050 1050
Lines 92480 92481 +1
Branches 1790 1790
============================================
- Hits 64549 64547 -2
- Misses 27040 27043 +3
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BowenXiao1999
force-pushed
the
bw/refine-doc
branch
2 times, most recently
from
1ad0468 to
3a53521
Compare
|
Will still conflict with #1654 🤪 Maybe you can also help resolve before this PR gets merged. |
BowenXiao1999
force-pushed
the
bw/refine-doc
branch
from
3a53521 to
1c85a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
It's a known TODO:
https://github.com/singularity-data/risingwave/blob/347406f35d1bb97fe8cd2a4e33cf67b4ff6298c2/src/utils/pgwire/src/pg_protocol.rs#L111-L112
Checklist
Refer to a related PR or issue link (optional)