Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 7, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

Also enabled debug symbols for release mode.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh requested a review from BugenZhao April 7, 2022 05:44
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1640 (0077a31) into main (7d7c75b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1640      +/-   ##
============================================
- Coverage     69.83%   69.80%   -0.03%     
  Complexity     2766     2766              
============================================
  Files          1050     1050              
  Lines         92385    92461      +76     
  Branches       1790     1790              
============================================
+ Hits          64516    64543      +27     
- Misses        26978    27027      +49     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.62% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/logging/src/lib.rs 0.78% <0.00%> (-0.02%) ⬇️
src/frontend/src/binder/statement.rs 68.42% <0.00%> (-8.05%) ⬇️
src/frontend/src/binder/insert.rs 86.11% <0.00%> (-5.07%) ⬇️
src/frontend/src/planner/select.rs 89.51% <0.00%> (-3.93%) ⬇️
src/source/src/parser/protobuf_parser.rs 86.23% <0.00%> (-1.62%) ⬇️
src/frontend/src/binder/expr/mod.rs 79.13% <0.00%> (-1.11%) ⬇️
src/frontend/src/planner/relation.rs 82.95% <0.00%> (-0.96%) ⬇️
src/frontend/src/binder/expr/function.rs 91.07% <0.00%> (-0.83%) ⬇️
src/common/src/error.rs 72.01% <0.00%> (-0.39%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.13% <0.00%> (-0.28%) ⬇️
... and 10 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh force-pushed the skyzh/compress-debug-section-ci branch from 34c1392 to b4d5e9b Compare April 7, 2022 05:52
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyzh skyzh enabled auto-merge (squash) April 7, 2022 06:06
@skyzh skyzh force-pushed the skyzh/compress-debug-section-ci branch from fba4959 to 0077a31 Compare April 7, 2022 06:10
@skyzh skyzh merged commit 45fc648 into main Apr 7, 2022
@skyzh skyzh deleted the skyzh/compress-debug-section-ci branch April 7, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants