Skip to content

chore: rename rust -> src #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2022
Merged

chore: rename rust -> src #1551

merged 2 commits into from
Apr 3, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 2, 2022 •
edited
Loading

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh marked this pull request as ready for review April 2, 2022 03:52
@skyzh skyzh marked this pull request as draft April 2, 2022 03:52
@skyzh skyzh marked this pull request as ready for review April 2, 2022 06:11
@skyzh skyzh force-pushed the skyzh/move branch 2 times, most recently from 97bcbff to 58843f8 Compare April 2, 2022 06:29
@skyzh skyzh requested review from BugenZhao and fuyufjh April 2, 2022 06:48
fuyufjh
fuyufjh approved these changes Apr 2, 2022
View reviewed changes
Copy link
Collaborator

@fuyufjh fuyufjh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇 As long as it can pass CI, LGTM

(Should merge tomorrow)

BugenZhao
BugenZhao approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may move Cargo.toml to the project root as well in next PRs.

@codecov
Copy link

codecov bot commented Apr 2, 2022 •
edited
Loading

Codecov Report

Merging #1551 (46282dc) into main (0d04771) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1551      +/-   ##
============================================
- Coverage     69.70%   69.70%   -0.01%     
  Complexity     2766     2766              
============================================
  Files          1042     1042              
  Lines         91601    91601              
  Branches       1790     1790              
============================================
- Hits          63852    63850       -2     
- Misses        26858    26860       +2     
  Partials        891      891
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/execution/local_exchange.rs 70.93% <ø> (ø)
src/batch/src/executor/create_source.rs 0.00% <ø> (ø)
src/batch/src/executor/create_table.rs 52.54% <ø> (ø)
src/batch/src/executor/delete.rs 80.89% <ø> (ø)
src/batch/src/executor/drop_stream.rs 0.00% <ø> (ø)
src/batch/src/executor/drop_table.rs 0.00% <ø> (ø)
src/batch/src/executor/filter.rs 75.83% <ø> (ø)
src/batch/src/executor/fuse.rs 98.55% <ø> (ø)
src/batch/src/executor/generate_series.rs 66.26% <ø> (ø)
src/batch/src/executor/generic_exchange.rs 59.42% <ø> (ø)
... and 923 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor Author

skyzh commented Apr 2, 2022

Will be merged on Sunday 12pm UTC+8

@skyzh skyzh merged commit 0f2d391 into main Apr 3, 2022
@skyzh skyzh deleted the skyzh/move branch April 3, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyufjh fuyufjh fuyufjh approved these changes

@BugenZhao BugenZhao BugenZhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyzh @fuyufjh @BugenZhao