Skip to content

chore: provide details of cherry pick github action and remind contributors #10664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmatz merged 1 commit into from
Jun 30, 2023
Merged

chore: provide details of cherry pick github action and remind contributors #10664

lmatz merged 1 commit into from
Jun 30, 2023

Conversation

@lmatz
Copy link
Contributor

@lmatz lmatz commented Jun 30, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Some contributor-facing documentation and changes to the pull request template.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

@github-actions github-actions bot added type/chore user-facing-changes Contains changes that are visible to users labels Jun 30, 2023
@lmatz lmatz force-pushed the lz/doc branch 2 times, most recently from 67ab947 to 7c1b67d Compare June 30, 2023 02:30
@lmatz lmatz removed the user-facing-changes Contains changes that are visible to users label Jun 30, 2023
@lmatz lmatz requested a review from huangjw806 June 30, 2023 03:55
@lmatz lmatz added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit 9f14ed9 Jun 30, 2023
@lmatz lmatz deleted the lz/doc branch June 30, 2023 06:37
huangjw806 pushed a commit that referenced this pull request Jun 30, 2023
@lmatz @huangjw806
chore: provide details of cherry pick github action and remind contri…
7ef5e03 
…butors (#10664)

collect risingwave logs when integration test failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@huangjw806 huangjw806 huangjw806 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lmatz @huangjw806